Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEATURE: upgrade migration tool rockhopper to v2 #1506

Merged
merged 4 commits into from
Jan 19, 2024
Merged

FEATURE: upgrade migration tool rockhopper to v2 #1506

merged 4 commits into from
Jan 19, 2024

Conversation

c9s
Copy link
Owner

@c9s c9s commented Jan 18, 2024

image

@bbgokarma-bot
Copy link

Welcome back! @c9s, This pull request may get 1592 BBG.

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 1607 BBG

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 1550 BBG

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 1555 BBG

@c9s c9s force-pushed the feature/rockhopper-v2 branch from 174f28c to cfa0468 Compare January 19, 2024 07:29
@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 1723 BBG

@codecov Codecov
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Attention: 228 lines in your changes are missing coverage. Please review.

Comparison is base (c01be14) 21.60% compared to head (cfa0468) 21.90%.
Report is 15 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1506      +/-   ##
==========================================
+ Coverage   21.60%   21.90%   +0.30%     
==========================================
  Files         605      602       -3     
  Lines       44101    43913     -188     
==========================================
+ Hits         9527     9620      +93     
+ Misses      33879    33593     -286     
- Partials      695      700       +5
Files Coverage Δ
pkg/types/time.go 25.47% <ø> (ø)
pkg/migrations/mysql/main_20200721225616_trades.go 7.31% <33.33%> (ø)
...igrations/mysql/main_20200819054742_trade_index.go 17.64% <33.33%> (ø)
pkg/migrations/mysql/main_20201102222546_orders.go 9.09% <33.33%> (ø)
...s/mysql/main_20201103173342_trades_add_order_id.go 17.64% <33.33%> (ø)
...ions/mysql/main_20201105092857_trades_index_fix.go 17.64% <33.33%> (ø)
...ions/mysql/main_20201105093056_orders_add_index.go 17.64% <33.33%> (ø)
pkg/migrations/mysql/main_20201106114742_klines.go 6.12% <33.33%> (ø)
...ons/mysql/main_20201211175751_fix_symbol_length.go 17.64% <33.33%> (ø)
...ions/mysql/main_20210118163847_fix_unique_index.go 17.64% <33.33%> (ø)
... and 68 more

... and 11 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c01be14...cfa0468. Read the comment docs.

@c9s c9s merged commit 0e5ff14 into main Jan 19, 2024
4 checks passed
@c9s c9s deleted the feature/rockhopper-v2 branch January 19, 2024 12:06
@bbgokarma-bot
Copy link

Hi @c9s,

Well done! 1733 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0xf5b96f2db3de0a0179b05018996e65a19add074b328d08ab61219dcff2962854

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narumiruna narumiruna narumiruna approved these changes

@huang47 huang47 Awaiting requested review from huang47

@zenixls2 zenixls2 Awaiting requested review from zenixls2

@ycdesu ycdesu Awaiting requested review from ycdesu

@kbearXD kbearXD Awaiting requested review from kbearXD

@gx578007 gx578007 Awaiting requested review from gx578007

@bailantaotao bailantaotao Awaiting requested review from bailantaotao

@andycheng123 andycheng123 Awaiting requested review from andycheng123

@austin362667 austin362667 Awaiting requested review from austin362667

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@c9s @bbgokarma-bot @narumiruna